Skip to content

refactor(@angular/ssr): remove custom Platform Server creation Logic #28728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2024
Merged

refactor(@angular/ssr): remove custom Platform Server creation Logic #28728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions packages/angular/ssr/src/routes/ng-routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,11 @@ import {
ApplicationRef,
Compiler,
Injector,
createPlatformFactory,
platformCore,
runInInjectionContext,
ɵwhenStable as whenStable,
ɵConsole,
} from '@angular/core';
import {
INITIAL_CONFIG,
ɵINTERNAL_SERVER_PLATFORM_PROVIDERS as INTERNAL_SERVER_PLATFORM_PROVIDERS,
} from '@angular/platform-server';
import { INITIAL_CONFIG, platformServer } from '@angular/platform-server';
import { Route, Router, ɵloadChildren as loadChildrenHelper } from '@angular/router';
import { ServerAssets } from '../assets';
import { Console } from '../console';
Expand Down Expand Up @@ -377,7 +372,7 @@ export async function getRoutesFromAngularRouterConfig(
const { protocol, host } = url;

// Create and initialize the Angular platform for server-side rendering.
const platformRef = createPlatformFactory(platformCore, 'server', [
const platformRef = platformServer([
{
provide: INITIAL_CONFIG,
useValue: { document, url: `${protocol}//${host}/` },
Expand All @@ -386,8 +381,7 @@ export async function getRoutesFromAngularRouterConfig(
provide: ɵConsole,
useFactory: () => new Console(),
},
...INTERNAL_SERVER_PLATFORM_PROVIDERS,
])();
]);

try {
let applicationRef: ApplicationRef;
Expand Down