Update peer deps angular 19.1 #29007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: minor
angular-robot
bot
added
area: build & ci
alan-agius4
force-pushed
the
update-peer-deps-angular-19.1
branch
from
367ef20 to
4be6eea
Compare
Whlist, this package is not really optional, NPM will install the wrong verson of peer dependencies when the Angular CLI is in prerelease mode. ```ts STDERR: npm error code ERESOLVE npm error ERESOLVE unable to resolve dependency tree npm error npm error While resolving: test-project@0.0.0 npm error Found: @angular/animations@19.1.0-next.0 npm error node_modules/@angular/animations npm error @angular/animations@"^19.1.0-next.0" from the root project npm error npm error Could not resolve dependency: npm error peer @angular/animations@"19.0.1" from @angular/platform-server@19.0.1 npm error node_modules/@angular/platform-server npm error peer @angular/platform-server@"^19.1.0-next.0 || ^19.0.0" from @angular/ssr@19.1.0-next.0 npm error node_modules/@angular/ssr npm error @angular/ssr@"19.1.0-next.0" from the root project npm error npm error Fix the upstream dependency conflict, or retry npm error this command with --force or --legacy-peer-deps ```
alan-agius4
force-pushed
the
update-peer-deps-angular-19.1
branch
from
4be6eea to
3de0d44
Compare
alan-agius4
force-pushed
the
update-peer-deps-angular-19.1
branch
from
3de0d44 to
232d35f
Compare
alan-agius4
added
the
action: review
clydin
approved these changes
Dec 2, 2024
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.