Skip to content

More migration work for rules_js #29166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2024
Merged

More migration work for rules_js #29166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
599f1a7
build: migrate remaining `angular-devkit/architect` to `ts_project`
devversion Dec 17, 2024
f4c85f2
build: migrate `angular-devkit/architect-cli` to `ts_project`
devversion Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions packages/angular_devkit/architect/node/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,42 +4,46 @@
# found in the LICENSE file at https://angular.dev/license

load("@npm//@bazel/jasmine:index.bzl", "jasmine_node_test")
load("//tools:defaults.bzl", "ts_library")
load("//tools:interop.bzl", "ts_project")

licenses(["notice"])

package(default_visibility = ["//visibility:public"])

ts_library(
ts_project(
name = "node",
srcs = glob(
include = ["**/*.ts"],
exclude = ["**/*_spec.ts"],
),
module_name = "@angular-devkit/architect/node",
module_root = "index.d.ts",
deps = [
"//packages/angular_devkit/architect",
interop_deps = [
"//packages/angular_devkit/core",
"//packages/angular_devkit/core/node",
"@npm//@types/node",
"@npm//rxjs",
],
module_name = "@angular-devkit/architect/node",
deps = [
"//:root_modules/@types/node",
"//:root_modules/rxjs",
"//packages/angular_devkit/architect:architect_rjs",
],
)

ts_library(
ts_project(
name = "node_test_lib",
testonly = True,
srcs = glob(
include = [
"**/*_spec.ts",
],
),
deps = [
":node",
"//packages/angular_devkit/architect",
interop_deps = [
"//tests/angular_devkit/architect/node/jobs:jobs_test_lib",
"@npm//rxjs",
],
deps = [
":node_rjs",
"//:root_modules/@types/jasmine",
"//:root_modules/rxjs",
"//packages/angular_devkit/architect:architect_rjs",
],
)

Expand Down
24 changes: 13 additions & 11 deletions packages/angular_devkit/architect_cli/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
load("//tools:defaults.bzl", "pkg_npm", "ts_library")
load("//tools:defaults.bzl", "pkg_npm")
load("//tools:interop.bzl", "ts_project")

# Copyright Google Inc. All Rights Reserved.
#
Expand All @@ -8,22 +9,23 @@ licenses(["notice"])

package(default_visibility = ["//visibility:public"])

ts_library(
ts_project(
name = "architect_cli",
package_name = "@angular-devkit/architect-cli",
srcs = [
"bin/architect.ts",
] + glob(["src/**/*.ts"]),
module_name = "@angular-devkit/architect-cli",
deps = [
"//packages/angular_devkit/architect",
"//packages/angular_devkit/architect/node",
interop_deps = [
"//packages/angular_devkit/core",
"//packages/angular_devkit/core/node",
"@npm//@types/node",
"@npm//@types/progress",
"@npm//@types/yargs-parser",
"@npm//ansi-colors",
],
module_name = "@angular-devkit/architect-cli",
deps = [
"//:root_modules/@types/node",
"//:root_modules/@types/progress",
"//:root_modules/@types/yargs-parser",
"//:root_modules/ansi-colors",
"//packages/angular_devkit/architect:architect_rjs",
"//packages/angular_devkit/architect/node:node_rjs",
],
)

Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
],
"@angular-devkit/schematics/tools": ["./packages/angular_devkit/schematics/tools/index"],
"@angular-devkit/schematics/testing": ["./packages/angular_devkit/schematics/testing/index"],
"@angular-devkit/architect/testing": ["./packages/angular_devkit/architect/testing/index"],
"@angular-devkit/architect/*": ["./packages/angular_devkit/architect/*/index"],
"@angular-devkit/build-webpack": ["./packages/angular_devkit/build_webpack"],
"@angular-devkit/*": ["./packages/angular_devkit/*/src"],
"@angular/*": ["./packages/angular/*/src"],
Expand Down
Loading