Skip to content

build: migrate @schematics/angular to npm_package #29342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

josephperrott
Copy link
Member

This allows us to use the package in the RJS pnpm workspace.

@josephperrott josephperrott added target: rc This PR is targeted for the next release-candidate action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project labels Jan 13, 2025
@devversion
Copy link
Member

@josephperrott this seems to be failing. Likely some files are not stamped (see the diff tool)

@devversion devversion added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 14, 2025
This allows us to use the package in the RJS pnpm workspace.
@josephperrott josephperrott removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 14, 2025
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion removed the request for review from clydin January 15, 2025 08:21
@alan-agius4 alan-agius4 merged commit cdfdc68 into angular:main Jan 15, 2025
30 checks passed
@alan-agius4
Copy link
Collaborator

The changes were merged into the following branches: main, 19.1.x

@josephperrott josephperrott deleted the migrate-schematics branch February 14, 2025 17:54
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants