fix(@angular/ssr): ensure loadChildren runs in correct injection context during route extraction
#30587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
state: blocked
target: minor
alan-agius4
added
action: review
alan-agius4
force-pushed
the
route-injector
branch
from
145b139 to
a57992e
Compare
jkrems
approved these changes
Jun 24, 2025
alan-agius4
removed
action: review
…ntext during route extraction Ensure that `loadChildren` functions are executed within the route’s specific injection context when extracting routes, aligning behavior with Angular’s dependency injection model. More context: angular/angular#62133 Closes angular#29483
alan-agius4
force-pushed
the
route-injector
branch
from
a57992e to
7abc115
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that
loadChildrenfunctions are executed within the route’s specific injection context when extracting routes, aligning behavior with Angular’s dependency injection model.More context: angular/angular#62133
Closes #29483
Blocking until thenextversion of@angular/routeris on NPM