Skip to content

refactor(@angular/cli): use .html as template extension for mcp modernize tool #30892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025

Conversation

cexbrayat
Copy link
Member

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

.ng.html is not used unless ngHtml is set to true when generating a component. but the current style guide does not recommend to use .ng.html.

What is the new behavior?

Uses .html instead.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

…nize tool

`.ng.html` is not used unless `ngHtml` is set to true when generating a component.
but the current style guide does not recommend to use `.ng.html`.
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cexbrayat, thanks for contribution.

In future, can you please group the changes into a single PR when changing the same files. As this creates a lot of noise for us.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Aug 13, 2025
@alan-agius4 alan-agius4 merged commit 721b690 into angular:main Aug 13, 2025
32 checks passed
@cexbrayat
Copy link
Member Author

@alan-agius4 Sorry about that, I'm reviewing and testing commits one by one, so I only find some things after already opening a PR to fix others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/cli target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants