refactor(@angular/build): align environment option parsing with CLI package #30909
+88
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackage The environment options in the build package are updated to align with the tristate parsing logic and environment variable checks found in the CLI package. This change introduces a `parseTristate` function to handle 'true', 'false', and undefined values from environment variables, providing more consistent behavior across the two packages.
clydin
added
the
action: review
jkrems
approved these changes
Aug 13, 2025
| return false; | ||
| } | ||
|
|
||
| return undefined; |
There was a problem hiding this comment.
Is it worth adding a TODO here and/or to log a warning? Or is this mostly unreachable because other things would intercept --flag=treu already?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The environment options in the build package are updated to align with the tristate parsing logic and environment variable checks found in the CLI package. This change introduces a
parseTristatefunction to handle 'true', 'false', and undefined values from environment variables, providing more consistent behavior across the two packages.