refactor(@angular/build): modularize unit-test builder with runner-specific logic #30910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecific logic The main `unit-test` builder is refactored to act as a dispatcher, delegating the core execution to runner-specific implementations. This change significantly improves the structure and maintainability of the testing infrastructure. Key changes: - A new `runners` directory is created within the `unit-test` builder to house runner-specific logic. - All Vitest-related logic is extracted from the main builder and moved into `runners/vitest/`. - The Karma bridge is moved into `runners/karma/`. - A new `test-discovery.ts` file is introduced to centralize test finding logic, with a TODO to move the implementation there in the future.
clydin
added
target: major
jkrems
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main
unit-testbuilder is refactored to act as a dispatcher, delegating the core execution to runner-specific implementations. This change significantly improves the structure and maintainability of the testing infrastructure.Key changes:
runnersdirectory is created within theunit-testbuilder to house runner-specific logic.runners/vitest/.runners/karma/.test-discovery.tsfile is introduced to centralize test finding logic, with a TODO to move the implementation there in the future.