fix(@angular/cli): improve bun lockfile detection and optimize lockfile checks #31135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le checks This commit refactors the package manager lockfile detection logic to: - Introduce a `LOCKFILE_NAMES` constant for better maintainability and clarity. - Enhance Bun lockfile detection by checking for both `bun.lockb` and `bun.lock`. - Optimize lockfile checks by reading the root directory files once and passing them to the `hasLockfile` method, reducing redundant file system operations. This addresses issues where Bun lockfiles might not have been correctly identified. closes angular#31128
alan-agius4
added
the
target: patch
clydin
approved these changes
Sep 8, 2025
alan-agius4
added
action: review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the package manager lockfile detection logic to:
LOCKFILE_NAMESconstant for better maintainability and clarity.bun.lockbandbun.lock.hasLockfilemethod, reducing redundant file system operations.This addresses issues where Bun lockfiles might not have been correctly identified.
closes #31128