Skip to content

Conversation

gioboa
Copy link
Contributor

@gioboa gioboa commented Sep 27, 2025

Thanks for this great project 🙏
I updated the examples for createNodeRequestHandler because I copied and pasted them and found some typos.

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@angular-robot angular-robot bot added the area: docs Related to the documentation label Sep 27, 2025
@alan-agius4 alan-agius4 self-requested a review September 27, 2025 13:43
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you kindly squash the commits?

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Sep 27, 2025
@gioboa gioboa force-pushed the docs/createNodeRequestHandler-example branch from 26b826e to 09d505d Compare September 27, 2025 14:15
@gioboa
Copy link
Contributor Author

gioboa commented Sep 27, 2025

LGTM, can you kindly squash the commits?

Done 👍

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Sep 27, 2025
@alan-agius4 alan-agius4 merged commit 3db1a17 into angular:main Sep 29, 2025
32 checks passed
@alan-agius4
Copy link
Collaborator

This PR was merged into the repository. The changes were merged into the following branches:

@gioboa gioboa deleted the docs/createNodeRequestHandler-example branch September 29, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants