Skip to content

Conversation

clydin
Copy link
Member

@clydin clydin commented Oct 6, 2025

When migrating the glob package to tinyglobby the expandDirectories option was left at its default value of true. This differs from the previous behavior and can inadvertently cause files that are not expected to be included to show up as tests.

Closes #31280

When migrating the glob package to `tinyglobby` the `expandDirectories`
option was left at its default value of `true`. This differs from the
previous behavior and can inadvertently cause files that are not expected
to be included to show up as tests.
@clydin clydin added the target: major This PR is targeted for the next major release label Oct 6, 2025
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 6, 2025
@clydin clydin requested a review from alan-agius4 October 6, 2025 16:55
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 6, 2025
@clydin clydin merged commit 50e330d into angular:main Oct 6, 2025
35 checks passed
@clydin clydin deleted the unit-test/glob-no-expand-dirs branch October 6, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screenshots generated by vitest browser mode generate errors
2 participants