Skip to content

Conversation

eruan
Copy link
Contributor

@eruan eruan commented Jan 14, 2017

asterisk is necessary

@clydin
Copy link
Member

clydin commented Jan 15, 2017

It would be cleaner if you reverted your previous PR #3734.
You can do this fairly easily from GitHub. Click on the link for the previous PR then scroll to the bottom and click "Revert". It will setup a new PR with the appropriate changes.

@beeman
Copy link
Contributor

beeman commented Jan 15, 2017

@eruan please refer to this issue about the usages of cnpm: #3886 .

This functionality should not be added through a PR that is about gitignore as it are 2 different things.

@hansl
Copy link
Contributor

hansl commented Jan 18, 2017

Fixed by #4083 already.

@hansl hansl closed this Jan 18, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants