feat(@angular/cli): use environmentSource key for environments #4705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
force-pushed
the
environment-source
branch
2 times, most recently
from
3bd4ed2
to
6e7f840
Compare
|
An alias should be added in |
Heavily based on @jsanchezgarcia work in angular#4476. Fix angular#3857 BREAKING CHANGE: A new environmentSource entry replaces the previous source entry inside environments. To migrate the code follow the example below: Before: ``` "environments": { "source": "environments/environment.ts", "dev": "environments/environment.ts", "prod": "environments/environment.prod.ts" } ``` After: ``` "environmentSource": "environments/environment.ts", "environments": { "dev": "environments/environment.ts", "prod": "environments/environment.prod.ts" } ```
filipesilva
force-pushed
the
environment-source
branch
from
6e7f840
to
1b3a5dd
Compare
hansl
suggested changes
Feb 15, 2017
| @@ -19,15 +19,16 @@ function _createAotPlugin(wco: WebpackConfigOptions, options: any) { | |||
| let hostOverrideFileSystem: any = {}; | |||
| // process environment file replacement | |||
| if (appConfig.environments) { | |||
| if (!('source' in appConfig.environments)) { | |||
| throw new SilentError(`Environment configuration does not contain "source" entry.`); | |||
| if (!appConfig.environmentSource) { | |||
There was a problem hiding this comment.
Please verify if environment.source is set here and explain to the user the change s/he needs to make.
Brocco
approved these changes
Feb 16, 2017
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
…ar#4705) Heavily based on @jsanchezgarcia work in angular#4476. Fix angular#3857 BREAKING CHANGE: A new environmentSource entry replaces the previous source entry inside environments. To migrate the code follow the example below: Before: ``` "environments": { "source": "environments/environment.ts", "dev": "environments/environment.ts", "prod": "environments/environment.prod.ts" } ``` After: ``` "environmentSource": "environments/environment.ts", "environments": { "dev": "environments/environment.ts", "prod": "environments/environment.prod.ts" } ```
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heavily based on @jsanchezgarcia work in #4476.
Fix #3857
BREAKING CHANGE:
A new
environmentSourceentry replaces the previoussourceentry insideenvironments.To migrate the code follow the example below:
Before:
After: