Skip to content

fix(@angular/cli): allow ts 2.2 #5586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2017
Merged

fix(@angular/cli): allow ts 2.2 #5586

merged 1 commit into from
Mar 24, 2017

Conversation

filipesilva
Copy link
Contributor

@filipesilva filipesilva commented Mar 23, 2017 •
edited
Loading

The CLI itself was locked to TS2.0/2.1, but that could case it to not use the project TS when users updated to 2.2.

Fix #5548

/cc @hansl

@filipesilva filipesilva requested a review from hansl March 23, 2017 13:34
@filipesilva filipesilva added this to the 1.0 Final Blocking milestone Mar 23, 2017
hansl
hansl suggested changes Mar 23, 2017
View reviewed changes
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot do that unfortunately. 2.2 does not work with angular 2 and Microsoft does not follow semver.

@filipesilva filipesilva deleted the update-ts-dep branch March 23, 2017 14:31
@filipesilva filipesilva restored the update-ts-dep branch March 23, 2017 14:34
@filipesilva filipesilva reopened this Mar 23, 2017
@filipesilva filipesilva deleted the update-ts-dep branch March 23, 2017 15:05
@filipesilva filipesilva mentioned this pull request Mar 23, 2017
Closed
@scttcper scttcper mentioned this pull request Mar 23, 2017
Closed
@filipesilva filipesilva restored the update-ts-dep branch March 23, 2017 16:33
@filipesilva filipesilva reopened this Mar 23, 2017
@filipesilva
fix(@angular/cli): allow ts 2.2
a8261fc 
The CLI itself was locked to TS2.0/2.1, but that could case it to not use the project TS when users updated to 2.2.
@filipesilva filipesilva changed the title fix(@angular/cli): allow ts 2.2 and up fix(@angular/cli): allow ts 2.2 Mar 23, 2017
@filipesilva
Copy link
Contributor Author

Fixed to only allow >=2.0.0 <2.3.0.

@filipesilva filipesilva mentioned this pull request Mar 23, 2017
Closed
1 task
@hansl hansl merged commit 5a461f1 into angular:master Mar 24, 2017
@filipesilva filipesilva deleted the update-ts-dep branch March 26, 2017 20:38
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@hansl hansl hansl approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERROR in AppModule is not an NgModule and TS 2.2.1
3 participants
@filipesilva @hansl @googlebot