Add option to adjust generated files via lint fix #6213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
reviewed
May 8, 2017
|
|
||
| const chalk = require('chalk'); | ||
| const EmberGenerateCommand = require('../ember-cli/lib/commands/generate'); |
There was a problem hiding this comment.
Does this mean ../ember-cli/lib/commands/generate' is no longer necessary?
There was a problem hiding this comment.
Yes.
A followup PR for general ember-cli cleanup is planned.
filipesilva
approved these changes
May 8, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
--lint-fixoption to all generate commands which will execute a lint fix task on (and only on) the modified files resulting from the generate command. There is also an.angular-cli.jsonoptiondefaults.lintFixto enable the option for the project or globally.This feature was created via several commits due to several foundational changes that were required. As a bonus, the lint configuration now also allows the
filesoption to be used without theprojectoption.Closes #6192