Skip to content

feat(@angular/cli): improve common bundling performance #6281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Jun 12, 2017
Merged

feat(@angular/cli): improve common bundling performance #6281

merged 1 commit into from Jun 12, 2017

Conversation

clydin
Copy link
Member

@clydin clydin commented May 11, 2017

This adds an asynchronously loaded common chunk.
For a medium-sized project, this reduced aggregate bundle size by ~10%.

Partially addresses #6204

sumitarora
sumitarora previously approved these changes May 15, 2017
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clydin it seems like the upcoming Webpack scope hoisting would fully address the issue.

It would be better to wait for that rather than implement an incomplete solution. What do you think?

@filipesilva
Copy link
Contributor

Turns out scope hoisting has absolutely no relevant to this PR. It LGTM but is missing a test, can you add one please?

@nathanmarks
Copy link

@clydin are you still working on this?

@clydin
Copy link
Member Author

clydin commented Jun 8, 2017

Yes. Barring any issues, release goal is for 1.2.

@nathanmarks
Copy link

@clydin Since 1.2-beta.1 is already out, and this is still missing a test requested by @filipesilva , is it still going to make it?

@Brocco Brocco merged commit f75b5a7 into angular:master Jun 12, 2017
@clydin clydin deleted the common-async branch June 12, 2017 14:18
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants