Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove codelyzer rules #6651

Merged
merged 1 commit into from
Jun 15, 2017
Merged

chore: remove codelyzer rules #6651

merged 1 commit into from
Jun 15, 2017

Conversation

mgechev
Copy link
Member

@mgechev mgechev commented Jun 12, 2017

Few codelyzer rules report warnings which are also compile-time errors caught by the
Angular compiler and reported by the language service.

Since codelyzer doesn't aim to provide type checking and deep analysis
of the entire project, it'll be better if these two rules are removed.

Btw, soon more rules will follow mgechev/codelyzer#314.

Few rules report warnings which are compile-time errors caught by the
Angular compiler and reported by the language service.

Since codelyzer doesn't aim to provide type checking and deep analysis
of the entire project, it'll be better if these two rules are removed.
@hansl
Copy link
Contributor

hansl commented Jun 15, 2017

We don't allow core: as a commit message anymore. This should probably be in ci:.

Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hansl hansl merged commit ac09d40 into angular:master Jun 15, 2017
Brocco pushed a commit that referenced this pull request Jun 15, 2017
Few rules report warnings which are compile-time errors caught by the
Angular compiler and reported by the language service.

Since codelyzer doesn't aim to provide type checking and deep analysis
of the entire project, it'll be better if these two rules are removed.
@mgechev mgechev deleted the remove-codelyzer-rules branch September 8, 2017 05:52
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018
Few rules report warnings which are compile-time errors caught by the
Angular compiler and reported by the language service.

Since codelyzer doesn't aim to provide type checking and deep analysis
of the entire project, it'll be better if these two rules are removed.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants