feat(test): karma integration and unit test sample #69
Conversation
| {pattern: 'src/test/matchers.js', included: true, watched: true}, | ||
|
|
||
| {pattern: 'dist/**/*.js', included: false, watched: true} | ||
| ], |
There was a problem hiding this comment.
what about source maps? don't you need to serve those too?
There was a problem hiding this comment.
also I don't see the proxy configuration to enable component template fetching from tests
|
Thanks for the feedback @IgorMinar. I totally forgot about the source maps. I'll add them and fix the other issues to get this merged. Todo:
|
cironunes
force-pushed
the
karma-integration
branch
4 times, most recently
from
55550a9 to
0ed045f
Compare
|
@IgorMinar I think that all the comments were addressed. One thing that is still missing though is the ability to run the tests using |
cironunes
force-pushed
the
karma-integration
branch
from
0ed045f to
d9194b6
Compare
|
|
| } | ||
| }); | ||
|
|
||
| System.import('angular2/src/core/dom/browser_adapter').then(function(browser_adapter) { |
There was a problem hiding this comment.
can you add a todo comment that once beta is out we should change this code to use a "test platform".
|
left a few comments. the rest looks good. can you please fix the issues and merge the PR into master? (I'll make sure you have commit rights). No merge commits please. Use rebase/fast-forward merges. |
cironunes
force-pushed
the
karma-integration
branch
2 times, most recently
from
ee712d3 to
7f7b308
Compare
cironunes
force-pushed
the
karma-integration
branch
from
7f7b308 to
9a55291
Compare
|
OK. Just waiting for the commit rights. |
|
check email. you should have an invite. On Wed, Nov 25, 2015 at 4:33 PM Ciro Nunes notifications@github.com wrote:
|
|
Landed as 4afd815 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
/cc @IgorMinar