feat(@angular/cli): Allow ability to set budget sizes for your bundles #7458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansl
reviewed
Aug 21, 2017
| "budgets": { | ||
| "description": "Defines the budget allotments for bundles.", | ||
| "type": "array", | ||
| "items": {"type": "object", |
hansl
reviewed
Aug 21, 2017
| "type": "string" | ||
| }, | ||
| "budget": { | ||
| "description": "Threshold to measure against. (in kb)", |
There was a problem hiding this comment.
I'd rather have a string or number, and string can contain g M or k or whatever.
hansl
reviewed
Aug 21, 2017
| @@ -192,6 +192,22 @@ | |||
| "description": "Name and corresponding file for environment config.", | |||
| "type": "object", | |||
| "additionalProperties": true | |||
| }, | |||
| "budgets": { | |||
There was a problem hiding this comment.
With this scheme, how do I specify the error/warning levels? How do I specify my budget for initial vs total?
hansl
suggested changes
Aug 21, 2017
|
This PR is the original version of the already merged #8939, closing. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7139