fix(@ngtools/webpack): fix #7615, check if this.done is defined before delaying resolvers #7619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rezonant
changed the title
hansl
reviewed
Sep 8, 2017
| @@ -390,7 +390,7 @@ export class AotPlugin implements Tapable { | |||
| // Wait for the plugin to be done when requesting `.ts` files directly (entry points), or | |||
| // when the issuer is a `.ts` file. | |||
| compiler.resolvers.normal.plugin('before-resolve', (request: any, cb: () => void) => { | |||
| if (request.request.endsWith('.ts') | |||
| if (this.done && request.request.endsWith('.ts') | |||
| || (request.context.issuer && request.context.issuer.endsWith('.ts'))) { | |||
| this.done!.then(() => cb(), () => cb()); | |||
There was a problem hiding this comment.
In that case, could you remove the ! here? It won't be needed.
clydin
reviewed
Sep 9, 2017
| @@ -390,9 +390,9 @@ export class AotPlugin implements Tapable { | |||
| // Wait for the plugin to be done when requesting `.ts` files directly (entry points), or | |||
| // when the issuer is a `.ts` file. | |||
| compiler.resolvers.normal.plugin('before-resolve', (request: any, cb: () => void) => { | |||
| if (request.request.endsWith('.ts') | |||
| if (this.done && request.request.endsWith('.ts') | |||
There was a problem hiding this comment.
bad logic? shouldn't it be:
if (this.done
&& (request.request.endsWith('.ts')
|| (request.context.issuer && request.context.issuer.endsWith('.ts')))) {
There was a problem hiding this comment.
Ah. I missed the second line (not a fan of the line break here). Fixed in next version.
Check if this.done is defined before delaying file access
hansl
approved these changes
Sep 13, 2017
filipesilva
pushed a commit
that referenced
this pull request
Dec 30, 2017
clydin
pushed a commit
that referenced
this pull request
Jan 11, 2018
dond2clouds
pushed a commit
to d2clouds/speedray-cli
that referenced
this pull request
Apr 23, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7615