fix(@ngtools/webpack): analyze the typescript file for additional dep… #7998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
reviewed
Oct 10, 2017
|
|
||
| export default async function() { | ||
| if (process.platform.startsWith('win')) { | ||
| return Promise.resolve(); |
There was a problem hiding this comment.
Should be able to just return; here. An async function will return a resolved promise with the returned value.
filipesilva
previously approved these changes
Oct 11, 2017
| await execAndWaitForOutputToMatch('ng', ['serve'], successRe); | ||
|
|
||
| await Promise.all([ | ||
| waitForAnyProcessOutputToMatch(successRe, 20000), |
There was a problem hiding this comment.
The rest of the PR LGTM but this test fails with the new plugin (Angular 5+).
There was a problem hiding this comment.
As it should, I need to fix that code path. Going to do that right now.
hansl
force-pushed
the
dependencies
branch
2 times, most recently
from
1ce0ee1 to
b0a5641
Compare
…endencies By default, Webpack only add dependencies it can see. Types or imports that are not kept in transpilations are removed, and webpack dont see them. By reading the AST directly we manually add the dependencies to webpack. Fixes angular#7995.
filipesilva
approved these changes
Oct 11, 2017
|
I confirmed (running nightly tests locally) that this work with the latest angular compiler. |
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Oct 12, 2017
See angular#7995 (comment) for details. Fix regression introduced in angular#7998
hansl
pushed a commit
that referenced
this pull request
Oct 12, 2017
See #7995 (comment) for details. Fix regression introduced in #7998
hansl
pushed a commit
that referenced
this pull request
Oct 12, 2017
See #7995 (comment) for details. Fix regression introduced in #7998
hansl
pushed a commit
that referenced
this pull request
Oct 12, 2017
See #7995 (comment) for details. Fix regression introduced in #7998
dond2clouds
pushed a commit
to d2clouds/speedray-cli
that referenced
this pull request
Apr 23, 2018
See angular#7995 (comment) for details. Fix regression introduced in angular#7998
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…endencies
By default, Webpack only add dependencies it can see. Types or imports that are not
kept in transpilations are removed, and webpack dont see them. By reading the AST
directly we manually add the dependencies to webpack.
Fixes #7995.