fix(@angular/cli): throw xi18n errors #8480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocombe
force-pushed
the
fix/#8065-ng-xi18n-errors
branch
from
b4afbc1 to
3c1ef98
Compare
filipesilva
suggested changes
Nov 14, 2017
| } | ||
|
|
||
| const json = stats.toJson('verbose'); | ||
| if (runTaskOptions.verbose) { |
There was a problem hiding this comment.
I'd prefer we didn't output bundle stats in xi18n since those bundles aren't actually generated on disk and we didn't outputt this information for xi18n before. Can you leave just the warning/error logic please?
ocombe
force-pushed
the
fix/#8065-ng-xi18n-errors
branch
from
3c1ef98 to
963da70
Compare
filipesilva
previously approved these changes
Nov 14, 2017
ocombe
force-pushed
the
fix/#8065-ng-xi18n-errors
branch
from
963da70 to
ec89514
Compare
filipesilva
suggested changes
Nov 14, 2017
filipesilva
previously approved these changes
Nov 14, 2017
ocombe
force-pushed
the
fix/#8065-ng-xi18n-errors
branch
from
ec89514 to
106b45f
Compare
filipesilva
approved these changes
Nov 20, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly throw xi18n errors (and print warnings) instead of ignoring them.
I've also removed the catch so that the extraction really fails when there is an error.
Fixes #8065