Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Documentation of directive priorities #2714

Closed
wants to merge 2 commits into from

Conversation

JensRantil
Copy link
Contributor

This fixes issue #2644.

@petebacondarwin
Copy link
Contributor

@JensRantil - is it an integer? Or a number? Have you tried putting in other values?

@JensRantil
Copy link
Contributor Author

is it an integer? Or a number? Have you tried putting in other values?

It's a number. Comparison is done using

function pseudoCompare(a, b) {
  b - a;
}

I've updated the pull request to reflect this.

I've also changed the commit messages to (hopefully!) follow commit message guidelines.

@@ -332,8 +332,9 @@ compiler}. The attributes are:

* `priority` - When there are multiple directives defined on a single DOM element, sometimes it
is necessary to specify the order in which the directives are applied. The `priority` is used
to sort the directives before their `compile` functions get called. Higher `priority` goes
first. The order of directives within the same priority is undefined.
to sort the directives before their `compile` functions get called. Priority is defined as an
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An > a

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@petebacondarwin
Copy link
Contributor

Thanks! Landed at 9d19b51 and 38ffbbd

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants