fix(select): reset select model if valid options changed by ng-options #6515
Conversation
Previously, changing the available options so the current model value was no longer valid would show no selection in the UI The model value would still be the old value. Closes angular#6379
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa to
fd2d6c0
Compare
jeffbcross
force-pushed
the
master
branch
2 times, most recently
from
cad9560 to
f294244
Compare
jeffbcross
force-pushed
the
master
branch
4 times, most recently
from
e8dc429 to
e83fab9
Compare
petebacondarwin
force-pushed
the
master
branch
from
4dd5a20 to
998c61c
Compare
|
This thankfully works in 1.4. Sorry we never took a look at this PR! :( |
Request Type: bug
How to reproduce: select model not reset if valid options changed by ng-options #6379
Component(s): forms
Impact: small
Complexity: small
This issue is related to:
Detailed Description:
select model not reset if valid options changed by ng-options #6379
Other Comments:
Previously, changing the available options so the current model value was no longer valid would show no selection in the UI
The model value would still be the old value.
Closes #6379
Feedback welcome!