Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(select): reset select model if valid options changed by ng-options #6515

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/ng/directive/select.js
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,11 @@ var selectDirective = ['$compile', '$parse', function($compile, $parse) {
while(optionGroupsCache.length > groupIndex) {
optionGroupsCache.pop()[0].element.remove();
}

if(!multiple && !selectedSet && modelValue !== null) {
// no value selected, clear model
ctrl.$setViewValue(undefined);
}
}
}
}
Expand Down
22 changes: 22 additions & 0 deletions test/ng/directive/selectSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -1113,6 +1113,28 @@ describe('select', function() {
browserTrigger(element, 'change');
expect(scope.selected).toEqual(null);
});

it('should clear model if ng-options change to not include selected value (#6379)', function() {
createSelect({
'ng-model': 'selected',
'ng-options': 'item for item in values'
});

scope.$apply(function() {
scope.values = ['A','B'];
scope.selected = scope.values[0];
});

expect(element.val()).toEqual('0');

expect(scope.selected).toEqual(scope.values[0]);

scope.$apply(function() {
scope.values = ['C','D'];
});
expect(element.val()).toEqual('?');
expect(scope.selected).toBeUndefined();
});
});


Expand Down