fix: prevent strictNullChecks support until #15432 is fixed #15434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorMinar
force-pushed
the
disable-strictNullChecks
branch
2 times, most recently
from
8f1adb0 to
e1269b1
Compare
IgorMinar
force-pushed
the
disable-strictNullChecks
branch
from
e1269b1 to
96dbd7f
Compare
| @@ -7,7 +7,8 @@ | |||
| "compilerOptions": { | |||
| "module": "es2015", | |||
| "moduleResolution": "node", | |||
| "strictNullChecks": true, | |||
| // TODO(i): strictNullChecks should turned on but are temporarily disabled due to #15432 | |||
There was a problem hiding this comment.
afaik // comments are not allowed in JSON
There was a problem hiding this comment.
hmm you are right microsoft/TypeScript#5450
interesting, thanks :)
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.