ng_package fixes #22499
Closed
ng_package fixes #22499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now add the 'main', 'module', 'es2015', and 'typings' properties, pointing to where the packaging tool lays them out. Fixes angular#22416
alexeagle
force-pushed
the
ng_package
branch
from
31432dd to
43150b4
Compare
|
You can preview 31432dd at https://pr22499-31432dd.ngbuilds.io/. |
chuckjaz
approved these changes
Feb 28, 2018
| * @param content current file content | ||
| */ | ||
| function amendPackageJson(filePath: string, content: string) { | ||
| if (path.basename(filePath) === 'package.json') { |
There was a problem hiding this comment.
Consider lifting this to the caller.
alexeagle
force-pushed
the
ng_package
branch
from
43150b4 to
eabfbaa
Compare
|
You can preview 43150b4 at https://pr22499-43150b4.ngbuilds.io/. |
|
You can preview eabfbaa at https://pr22499-eabfbaa.ngbuilds.io/. |
alexeagle
added
area: bazel
This was referenced Mar 15, 2018
This was referenced Mar 15, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.