Add API doc for NgModules #25618

jbogarthyde · 2018-08-22T15:54:23Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

mary-poppins · 2018-08-23T01:13:14Z

You can preview 3cea809 at https://pr25618-3cea809.ngbuilds.io/.

mary-poppins · 2018-08-29T18:36:25Z

You can preview 97a91e7 at https://pr25618-97a91e7.ngbuilds.io/.

mary-poppins · 2018-08-30T15:19:20Z

You can preview b8ff159 at https://pr25618-b8ff159.ngbuilds.io/.

IgorMinar · 2018-08-30T20:26:44Z

packages/common/http/src/module.ts

"the i" typo?

mary-poppins · 2018-08-31T15:32:31Z

You can preview 812bd83 at https://pr25618-812bd83.ngbuilds.io/.

mary-poppins · 2018-08-31T16:49:27Z

You can preview 2de9f6a at https://pr25618-2de9f6a.ngbuilds.io/.

mary-poppins · 2018-09-03T15:23:43Z

You can preview 7132b25 at https://pr25618-7132b25.ngbuilds.io/.

mhevery

Conditional on removing the merge conflict markers.

mhevery · 2018-09-10T18:25:05Z

packages/forms/src/form_providers.ts

merge conflict tags should be resolved

mary-poppins · 2018-09-14T19:46:23Z

You can preview 5f63355 at https://pr25618-5f63355.ngbuilds.io/.

mary-poppins · 2018-09-17T20:41:12Z

You can preview 7d2de5e at https://pr25618-7d2de5e.ngbuilds.io/.

trotyl · 2018-09-18T02:53:19Z

packages/platform-browser/animations/src/module.ts

NoopAnimationsModule has always been a public API, what does internal mean?

It's not private, but Mattias tells me it is only used internally to prevent undefined problems when animations are not in active use (or something along those lines). He didn't see any reason for developers to use it.

Importing NoopAnimationsModule is currently the only way to disable animations in the application: #20002, angular/components#10590

trotyl · 2018-09-18T02:54:13Z

packages/common/http/src/module.ts

JSON -> JSONP?

trotyl · 2018-09-18T02:59:01Z

packages/platform-browser/src/browser.ts

ApplicationModule has no exports, could be making their exports and providers available.

mary-poppins · 2018-09-18T17:17:40Z

You can preview f02bfe4 at https://pr25618-f02bfe4.ngbuilds.io/.

mary-poppins · 2018-09-18T17:33:45Z

You can preview b8868f4 at https://pr25618-b8868f4.ngbuilds.io/.

ngbot · 2018-09-18T21:59:11Z

I see that you just added the PR action: merge label, but the following checks are still failing:
status "ci/circleci: integration_test" is failing
status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

jenniferfell · 2018-09-18T21:59:32Z

LGTM. We just need a googler to run the g3 presubmit tests for us. Thanks!

mary-poppins · 2018-09-19T16:16:05Z

You can preview 6f26cc5 at https://pr25618-6f26cc5.ngbuilds.io/.

mary-poppins · 2018-09-19T16:19:27Z

You can preview cdec7a5 at https://pr25618-cdec7a5.ngbuilds.io/.

benlesh · 2018-09-19T17:41:52Z

@jenniferfell ... no g3 presubmit required for documentation-only changes. 👍

PR Close #25618

angular-automatic-lock-bot · 2019-09-14T01:52:06Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

jbogarthyde added comp: docs target: patch This PR is targeted for the next patch release labels Aug 22, 2018

googlebot added the cla: yes label Aug 22, 2018

jbogarthyde requested a review from mhevery August 22, 2018 16:20

jbogarthyde mentioned this pull request Aug 29, 2018

aio: missing descriptions on modules API docs #18572

Closed

jbogarthyde force-pushed the jb-apidoc-ngmodule branch 2 times, most recently from 059c74a to 97a91e7 Compare August 29, 2018 18:25

jbogarthyde force-pushed the jb-apidoc-ngmodule branch from 97a91e7 to b8ff159 Compare August 30, 2018 15:06

IgorMinar reviewed Aug 30, 2018

View reviewed changes

packages/common/http/src/module.ts Outdated

Copy link

Contributor

IgorMinar Aug 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the i" typo?

jbogarthyde reacted with thumbs up emoji

jbogarthyde force-pushed the jb-apidoc-ngmodule branch from b8ff159 to 812bd83 Compare August 31, 2018 15:19

jbogarthyde force-pushed the jb-apidoc-ngmodule branch from 7132b25 to 9719b35 Compare September 3, 2018 15:20

mhevery approved these changes Sep 10, 2018

View reviewed changes

packages/forms/src/form_providers.ts Outdated

Copy link

Contributor

mhevery Sep 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge conflict tags should be resolved

jbogarthyde force-pushed the jb-apidoc-ngmodule branch 3 times, most recently from 43f3438 to 6eb2ca2 Compare September 13, 2018 15:19

jbogarthyde force-pushed the jb-apidoc-ngmodule branch from 5f63355 to 7d2de5e Compare September 17, 2018 20:32

trotyl reviewed Sep 18, 2018

View reviewed changes

jbogarthyde force-pushed the jb-apidoc-ngmodule branch from 7d2de5e to f02bfe4 Compare September 18, 2018 17:10

jbogarthyde force-pushed the jb-apidoc-ngmodule branch from dd960a5 to b8868f4 Compare September 18, 2018 17:26

jbogarthyde added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Sep 18, 2018

jenniferfell added the action: merge The PR is ready for merge by the caretaker label Sep 18, 2018

docs: add ngmodule api doc

6f26cc5

jbogarthyde force-pushed the jb-apidoc-ngmodule branch from b8868f4 to 6f26cc5 Compare September 19, 2018 16:07

fixup! docs: add ngmodule api doc

cdec7a5

benlesh closed this in dd5e35e Sep 19, 2018

benlesh pushed a commit that referenced this pull request Sep 19, 2018

docs: add ngmodule api doc (#25618)

a41f331

PR Close #25618

jbogarthyde deleted the jb-apidoc-ngmodule branch September 19, 2018 20:52

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019

Add API doc for NgModules #25618

Add API doc for NgModules #25618

Uh oh!

Conversation

jbogarthyde commented Aug 22, 2018

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

mary-poppins commented Aug 23, 2018

Uh oh!

mary-poppins commented Aug 29, 2018

Uh oh!

mary-poppins commented Aug 30, 2018

Uh oh!

IgorMinar Aug 30, 2018

Choose a reason for hiding this comment

Uh oh!

mary-poppins commented Aug 31, 2018

Uh oh!

mary-poppins commented Aug 31, 2018

Uh oh!

mary-poppins commented Sep 3, 2018

Uh oh!

mhevery left a comment

Choose a reason for hiding this comment

Uh oh!

mhevery Sep 10, 2018

Choose a reason for hiding this comment

Uh oh!

mary-poppins commented Sep 14, 2018

Uh oh!

mary-poppins commented Sep 17, 2018

Uh oh!

trotyl Sep 18, 2018

Choose a reason for hiding this comment

Uh oh!

jbogarthyde Sep 18, 2018

Choose a reason for hiding this comment

Uh oh!

trotyl Sep 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

trotyl Sep 18, 2018

Choose a reason for hiding this comment

Uh oh!

trotyl Sep 18, 2018

Choose a reason for hiding this comment

Uh oh!

mary-poppins commented Sep 18, 2018

Uh oh!

mary-poppins commented Sep 18, 2018

Uh oh!

ngbot bot commented Sep 18, 2018

Uh oh!

jenniferfell commented Sep 18, 2018

Uh oh!

mary-poppins commented Sep 19, 2018

Uh oh!

mary-poppins commented Sep 19, 2018

Uh oh!

benlesh commented Sep 19, 2018

Uh oh!

angular-automatic-lock-bot bot commented Sep 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

trotyl Sep 19, 2018 •

edited

Loading