Skip to content

Conversation

@Zizzamia
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

This adds Leonardo Zizzamia to the list of Angular GDEs on the Angular Docs page -> cc @StephenFluin

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 'GDE'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @StephenFluin

Copy link
Contributor

@StephenFluin StephenFluin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jenniferfell jenniferfell added comp: docs state: community Someone from the Angular community is working on this issue or submitted this PR labels Oct 9, 2018
Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update git commit message to docs: add Leonardo Zizzamia to GDE resources

@brandonroberts brandonroberts changed the title docs(aio): add Leonardo Zizzamia to GDE resources docs: add Leonardo Zizzamia to GDE resources Jan 22, 2019
@ngbot ngbot bot added this to the needsTriage milestone Jan 24, 2019
@brandonroberts brandonroberts added risk: low feature Issue that requests a new feature effort1: hours labels Jan 29, 2019
@brandonroberts brandonroberts self-assigned this Jan 29, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Jan 29, 2019
@brandonroberts
Copy link
Contributor

@Zizzamia will you rebase on master and update the git commit message?

@brandonroberts brandonroberts added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 29, 2019
@Zizzamia Zizzamia requested a review from IgorMinar as a code owner January 30, 2019 00:58
@Zizzamia Zizzamia requested a review from a team January 30, 2019 00:58
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@Zizzamia Zizzamia force-pushed the update-gde-profile branch 2 times, most recently from eae08c8 to 1bcc2d5 Compare January 30, 2019 19:47
@googlebot
Copy link

CLAs look good, thanks!

@brandonroberts brandonroberts added target: patch This PR is targeted for the next patch release and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jan 30, 2019
@brandonroberts
Copy link
Contributor

@Zizzamia will you rebase again to fix the merge conflict? Thanks.

@brandonroberts brandonroberts force-pushed the update-gde-profile branch 2 times, most recently from 214faa7 to 0551cd7 Compare February 25, 2019 18:41
@brandonroberts brandonroberts added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Feb 25, 2019
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label Feb 25, 2019
benlesh pushed a commit that referenced this pull request Feb 25, 2019
@benlesh benlesh closed this in 1930e8a Feb 25, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours feature Issue that requests a new feature merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants