-
Notifications
You must be signed in to change notification settings - Fork 26.9k
docs: use self-closing component tags and perform minor cleanup #64880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| @Component({ | ||
| selector: 'app-housing-location', | ||
| imports: [RouterModule], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do this change we'll want to update the instructions in adev/src/content/tutorials/first-app/steps/10-routing/README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I was wondering if replacing the tutorial or adding a note like this would be better?
What do you think?
Note: Importing RouterModule provides all the router directives including RouterOutlet, RouterLink and RouterLinkActive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll want to be explicit on the imports. The less we talk about ngModules the better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, I also updated the syntax highlighting so that the provided examples are easier to read.
ae29f60 to
489308c
Compare
|
Looks like we need a rebase. |
489308c to
7776c75
Compare
|
@SkyZeroZx looks like this has files out of format. |
…ctives, and fix syntax highlighting
7776c75 to
aacbc30
Compare
Updated |


PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information