Skip to content

Conversation

@SkyZeroZx
Copy link
Contributor

@SkyZeroZx SkyZeroZx commented Nov 4, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from kirjs November 4, 2025 04:04
@angular-robot angular-robot bot added the area: docs Related to the documentation label Nov 4, 2025
@ngbot ngbot bot added this to the Backlog milestone Nov 4, 2025

@Component({
selector: 'app-housing-location',
imports: [RouterModule],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do this change we'll want to update the instructions in adev/src/content/tutorials/first-app/steps/10-routing/README.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I was wondering if replacing the tutorial or adding a note like this would be better?

What do you think?

Note: Importing RouterModule provides all the router directives including RouterOutlet, RouterLink and RouterLinkActive.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll want to be explicit on the imports. The less we talk about ngModules the better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, I also updated the syntax highlighting so that the provided examples are easier to read.

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 8, 2025
@ngbot
Copy link

ngbot bot commented Nov 8, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure conflicts with base branch "main"
    pending status "pullapprove" is pending
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@JeanMeche JeanMeche removed the request for review from kirjs November 8, 2025 11:48
@JeanMeche JeanMeche removed the action: merge The PR is ready for merge by the caretaker label Nov 8, 2025
@JeanMeche
Copy link
Member

Looks like we need a rebase.

@thePunderWoman
Copy link
Contributor

@SkyZeroZx looks like this has files out of format.

@SkyZeroZx
Copy link
Contributor Author

@SkyZeroZx looks like this has files out of format.

Updated

@thePunderWoman thePunderWoman added the action: merge The PR is ready for merge by the caretaker label Nov 12, 2025
@thePunderWoman thePunderWoman merged commit 4544135 into angular:main Nov 12, 2025
19 checks passed
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants