Skip to content

docs: remove tslint, codelyzer & protractor from dev deps #41826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Apr 27, 2021

TSLint and Codelyzer were deprecated in v11.
Protractor is no longer installed by default in new projects in v12.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

TSLint and Codelyzer were deprecated in v11.
Protractor is no longer installed by default in new projects in v12.
@kyliau kyliau added the target: patch This PR is targeted for the next patch release label Apr 27, 2021
@google-cla google-cla bot added the cla: yes label Apr 27, 2021
@pullapprove pullapprove bot requested a review from IgorMinar April 27, 2021 03:21
@kyliau kyliau requested review from aikithoughts and removed request for IgorMinar April 27, 2021 03:22
@pullapprove pullapprove bot requested a review from IgorMinar April 27, 2021 03:22
@kyliau kyliau requested review from jelbourn and removed request for IgorMinar April 27, 2021 03:22
Copy link
Contributor

@aikithoughts aikithoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: global-docs-approvers

@ngbot ngbot bot added this to the Backlog milestone Apr 27, 2021
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyliau kyliau added the action: merge The PR is ready for merge by the caretaker label Apr 28, 2021
jessicajaniuk pushed a commit that referenced this pull request Apr 28, 2021
TSLint and Codelyzer were deprecated in v11.
Protractor is no longer installed by default in new projects in v12.

PR Close #41826
jessicajaniuk pushed a commit that referenced this pull request Apr 28, 2021
TSLint and Codelyzer were deprecated in v11.
Protractor is no longer installed by default in new projects in v12.

PR Close #41826
@kyliau kyliau deleted the remove-tslint branch April 28, 2021 21:40
@cexbrayat cexbrayat mentioned this pull request Apr 29, 2021
14 tasks
cexbrayat added a commit to cexbrayat/angular that referenced this pull request Apr 29, 2021
Follow-up to angular#41826

The CLI now no longer installs `ts-node` since Protractor has been removed.
See angular/angular-cli#20601 for the relevant PR in angular-cli.
This change has been released in the CLI v12.0.0-rc.1
mhevery pushed a commit that referenced this pull request Apr 29, 2021
Follow-up to #41826

The CLI now no longer installs `ts-node` since Protractor has been removed.
See angular/angular-cli#20601 for the relevant PR in angular-cli.
This change has been released in the CLI v12.0.0-rc.1

PR Close #41873
mhevery pushed a commit that referenced this pull request Apr 29, 2021
Follow-up to #41826

The CLI now no longer installs `ts-node` since Protractor has been removed.
See angular/angular-cli#20601 for the relevant PR in angular-cli.
This change has been released in the CLI v12.0.0-rc.1

PR Close #41873
cexbrayat added a commit to cexbrayat/angular that referenced this pull request May 5, 2021
A recent commit 3b58903 reintroduced these dev deps.
They were previously removed by angular#41826 and angular#41873
mhevery pushed a commit that referenced this pull request May 5, 2021
A recent commit 3b58903 reintroduced these dev deps.
They were previously removed by #41826 and #41873

PR Close #41950
mhevery pushed a commit that referenced this pull request May 5, 2021
A recent commit 3b58903 reintroduced these dev deps.
They were previously removed by #41826 and #41873

PR Close #41950
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants