fix(@schematics/angular): remove ts-node and jasmine-spec-reporter from default workspace #20601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
reviewed
Apr 22, 2021
alan-agius4
added
action: cleanup
cexbrayat
force-pushed
the
fix/jasmine-spec-reporter
branch
from
fef0911
to
5ec8123
Compare
…om default workspace The dependencies are only needed for protractor tests, so they should only be added by the e2e schematics.
cexbrayat
force-pushed
the
fix/jasmine-spec-reporter
branch
from
5ec8123
to
45e4450
Compare
|
@alan-agius4 Sure, done 👍 |
alan-agius4
added
action: merge
cexbrayat
changed the title
14 tasks
cexbrayat
added a commit
to cexbrayat/angular
that referenced
this pull request
Apr 29, 2021
Follow-up to angular#41826 The CLI now no longer installs `ts-node` since Protractor has been removed. See angular/angular-cli#20601 for the relevant PR in angular-cli. This change has been released in the CLI v12.0.0-rc.1
mhevery
pushed a commit
to angular/angular
that referenced
this pull request
Apr 29, 2021
Follow-up to #41826 The CLI now no longer installs `ts-node` since Protractor has been removed. See angular/angular-cli#20601 for the relevant PR in angular-cli. This change has been released in the CLI v12.0.0-rc.1 PR Close #41873
mhevery
pushed a commit
to angular/angular
that referenced
this pull request
Apr 29, 2021
Follow-up to #41826 The CLI now no longer installs `ts-node` since Protractor has been removed. See angular/angular-cli#20601 for the relevant PR in angular-cli. This change has been released in the CLI v12.0.0-rc.1 PR Close #41873
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency is only needed for protractor tests, so it should only be added by the e2e schematics.