perf(core): make more `ApplicationModule` providers tree-shakable #45102

AndrewKushnir · 2022-02-16T06:34:37Z

This PR refactors ApplicationModule providers to make them tree-shakable. See individual commits for additional details.

PR Type

What kind of change does this PR introduce?

Performance improvement

Does this PR introduce a breaking change?

Yes
No

packages/core/src/application_module.ts

AndrewKushnir · 2022-02-16T06:52:37Z

Presubmit.

The `SCHEDULER` provider was used previously when both ViewEngine and Ivy code was present. After some prior refactoring, all references to the `SCHEDULER` token were removed, but the token itself remains present in the `ApplicationModule`, which makes it non-tree-shakable. This commit removes the `SCHEDULER` token as unused.

…tus` tree-shakable The `Compiler`, `ApplicationRef` and `ApplicationInitStatus` classes are registered as non-tree-shakable providers in the `ApplicationModule`. This commit converts them to the tree-shakable providers instead.

…` tree-shakable The `ApplicationModule` module has a number of tokens declared as non-tree-shakable providers. This commit updates them to make tree-shakable.

atscott

reviewed-for: size-tracking

jessicajaniuk

LGTM 🍪

reviewed-for: size-tracking

AndrewKushnir · 2022-02-17T22:56:13Z

"Green" TGP.

alxhub · 2022-02-18T21:39:41Z

Note: this doesn't merge cleanly to 13.2.x.

alxhub · 2022-02-18T21:40:04Z

This PR was merged into the repository by commit 1e60fe0.

…tus` tree-shakable (#45102) The `Compiler`, `ApplicationRef` and `ApplicationInitStatus` classes are registered as non-tree-shakable providers in the `ApplicationModule`. This commit converts them to the tree-shakable providers instead. PR Close #45102

…` tree-shakable (#45102) The `ApplicationModule` module has a number of tokens declared as non-tree-shakable providers. This commit updates them to make tree-shakable. PR Close #45102

The `SCHEDULER` provider was used previously when both ViewEngine and Ivy code was present. After some prior refactoring, all references to the `SCHEDULER` token were removed, but the token itself remains present in the `ApplicationModule`, which makes it non-tree-shakable. This commit removes the `SCHEDULER` token as unused. PR Close angular#45102

…tus` tree-shakable (angular#45102) The `Compiler`, `ApplicationRef` and `ApplicationInitStatus` classes are registered as non-tree-shakable providers in the `ApplicationModule`. This commit converts them to the tree-shakable providers instead. PR Close angular#45102

…` tree-shakable (angular#45102) The `ApplicationModule` module has a number of tokens declared as non-tree-shakable providers. This commit updates them to make tree-shakable. PR Close angular#45102

The `SCHEDULER` provider was used previously when both ViewEngine and Ivy code was present. After some prior refactoring, all references to the `SCHEDULER` token were removed, but the token itself remains present in the `ApplicationModule`, which makes it non-tree-shakable. This commit removes the `SCHEDULER` token as unused. PR Close #45102 PR Close #45222

…tus` tree-shakable (#45102) (#45222) The `Compiler`, `ApplicationRef` and `ApplicationInitStatus` classes are registered as non-tree-shakable providers in the `ApplicationModule`. This commit converts them to the tree-shakable providers instead. PR Close #45102 PR Close #45222

…` tree-shakable (#45102) (#45222) The `ApplicationModule` module has a number of tokens declared as non-tree-shakable providers. This commit updates them to make tree-shakable. PR Close #45102 PR Close #45222

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2fanimations/13.2.4/13.2.5) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcommon/13.2.4/13.2.5) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/13.2.4/13.2.5) | | [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/13.2.4/13.2.5) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcore/13.2.4/13.2.5) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2fforms/13.2.4/13.2.5) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/13.2.4/13.2.5) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/13.2.4/13.2.5) | | [@angular/router](https://github.com/angular/angular) | dependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2frouter/13.2.4/13.2.5) | | [zone.js](https://github.com/angular/angular) ([changelog](https://github.com/angular/angular/blob/master/packages/zone.js/CHANGELOG.md)) | dependencies | patch | [`0.11.4` -> `0.11.5`](https://renovatebot.com/diffs/npm/zone.js/0.11.4/0.11.5) | --- ### Release Notes <details> <summary>angular/angular (@angular/animations)</summary> ### [`v13.2.5`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#1325-2022-03-02) [Compare Source](angular/angular@13.2.4...13.2.5) ##### animations | Commit | Type | Description | | -- | -- | -- | | [6c61d20476](angular/angular@6c61d20) | fix | allow animations with unsupported CSS properties ([#45185](angular/angular#45185)) | ##### common | Commit | Type | Description | | -- | -- | -- | | [64da1daa78](angular/angular@64da1da) | fix | canceled JSONP requests won't throw console error with missing callback function ([#36807](angular/angular#36807)) | | [56ca7d385b](angular/angular@56ca7d3) | perf | make `NgLocalization` token tree-shakable ([#45118](angular/angular#45118)) ([#45226](angular/angular#45226)) | ##### compiler-cli | Commit | Type | Description | | -- | -- | -- | | [6c906a5bb9](angular/angular@6c906a5) | fix | Support resolve animation name from the DTS ([#45169](angular/angular#45169)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [e8fd452bd2](angular/angular@e8fd452) | fix | remove individual commands for updating gold files ([#45198](angular/angular#45198)) | | [82d772857c](angular/angular@82d7728) | perf | make `Compiler`, `ApplicationRef` and `ApplicationInitStatus` tree-shakable ([#45102](angular/angular#45102)) ([#45222](angular/angular#45222)) | | [71ff12c1cc](angular/angular@71ff12c) | perf | make `LOCALE_ID` and other tokens from `ApplicationModule` tree-shakable ([#45102](angular/angular#45102)) ([#45222](angular/angular#45222)) | ##### localize | Commit | Type | Description | | -- | -- | -- | | [d388522745](angular/angular@d388522) | fix | avoid imports into `compiler-cli` package ([#45180](angular/angular#45180)) | #### Special Thanks Andrew Kushnir, Andrew Scott, Charles Lyding, Guillaume Bonnet, Jessica Janiuk, JoostK, Martin Sikora, Paul Gschwendtner, Theodore Brown, dario-piotrowicz and ivanwonder  </details> <details> <summary>angular/angular (zone.js)</summary> ### [`v0.11.5`](https://github.com/angular/angular/blob/HEAD/packages/zone.js/CHANGELOG.md#0115-httpsgithubcomangularangularcomparezonejs-0114zonejs-0115-2022-03-03) [Compare Source](angular/angular@zone.js-0.11.4...zone.js-0.11.5) ##### Bug Fixes - **zone.js:** async-test should only call done once ([#45025](angular/angular#45025)) ([dea7234](angular/angular@dea7234)) - **zone.js:** defineProperties should also set symbol props ([#45098](angular/angular#45098)) ([b437d12](angular/angular@b437d12)), closes [#44095](angular/angular#44095) - **zone.js:** fix several test cases which trigger `done()` multiple times ([#45025](angular/angular#45025)) ([d5565cc](angular/angular@d5565cc)) - **zone.js:** only one listener should also re-throw an error correctly ([#41868](angular/angular#41868)) ([299f92c](angular/angular@299f92c)), closes [#41867](angular/angular#41867) [/github.com/angular/angular/pull/41562#issuecomment-822696973](https://github.com//github.com/angular/angular/pull/41562/issues/issuecomment-822696973) - **zone.js:** patch global instead of Mocha object ([#45047](angular/angular#45047)) ([8efbdb5](angular/angular@8efbdb5)), closes [#42834](angular/angular#42834) - **zone.js:** should continue to executue listeners when throw error ([#41562](angular/angular#41562)) ([008eaf3](angular/angular@008eaf3)), closes [#41522](angular/angular#41522) - **zone.js:** update several flaky cases ([#41526](angular/angular#41526)) ([25a83eb](angular/angular@25a83eb)), closes [#41434](angular/angular#41434) ##### Features - **zone.js:** add Promise.any() implementation ([#45064](angular/angular#45064)) ([4d494d2](angular/angular@4d494d2)), closes [#44393](angular/angular#44393) - **zone.js:** update electron patch to support electron/remote 14 ([#45073](angular/angular#45073)) ([d65706a](angular/angular@d65706a)), closes [#43346](angular/angular#43346) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1197 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

angular-automatic-lock-bot · 2022-03-21T16:11:46Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

…` tree-shakable (angular#45102) The `ApplicationModule` module has a number of tokens declared as non-tree-shakable providers. This commit updates them to make tree-shakable. PR Close angular#45102

AndrewKushnir added state: WIP area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release cross-cutting: tree-shaking labels Feb 16, 2022

ngbot bot modified the milestone: Backlog Feb 16, 2022

AndrewKushnir commented Feb 16, 2022

View reviewed changes

packages/core/src/application_module.ts Outdated Show resolved Hide resolved

AndrewKushnir force-pushed the app_module_refactor branch 2 times, most recently from b2b8d26 to 503839c Compare February 16, 2022 22:53

AndrewKushnir changed the title ~~refactor(core): make more ApplicationModule providers tree-shakable~~ perf(core): make more ApplicationModule providers tree-shakable Feb 16, 2022

AndrewKushnir force-pushed the app_module_refactor branch from 503839c to 17b7881 Compare February 17, 2022 00:16

AndrewKushnir added 2 commits February 16, 2022 16:17

perf(core): make LOCALE_ID and other tokens from `ApplicationModule…

a166e1b

…` tree-shakable The `ApplicationModule` module has a number of tokens declared as non-tree-shakable providers. This commit updates them to make tree-shakable.

AndrewKushnir force-pushed the app_module_refactor branch from 17b7881 to a166e1b Compare February 17, 2022 00:17

AndrewKushnir requested a review from alxhub February 17, 2022 00:18

AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Feb 17, 2022

AndrewKushnir marked this pull request as ready for review February 17, 2022 00:19

pullapprove bot requested review from atscott, jelbourn and jessicajaniuk February 17, 2022 00:19

atscott approved these changes Feb 17, 2022

View reviewed changes

pullapprove bot requested a review from dylhunn February 17, 2022 21:55

atscott approved these changes Feb 17, 2022

View reviewed changes

jessicajaniuk approved these changes Feb 17, 2022

View reviewed changes

jessicajaniuk removed the request for review from jelbourn February 17, 2022 21:58

jessicajaniuk removed request for alxhub and dylhunn February 17, 2022 21:58

jessicajaniuk added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 17, 2022

AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label Feb 17, 2022

alxhub added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Feb 18, 2022

alxhub closed this in fcd0473 Feb 18, 2022

AndrewKushnir mentioned this pull request Mar 1, 2022

[13.2.x] perf(core): make more ApplicationModule providers tree-shakable #45222

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

perf(core): make more `ApplicationModule` providers tree-shakable #45102

perf(core): make more `ApplicationModule` providers tree-shakable #45102

Uh oh!

AndrewKushnir commented Feb 16, 2022 •

edited

Loading

Uh oh!

Uh oh!

AndrewKushnir commented Feb 16, 2022

Uh oh!

atscott left a comment

Uh oh!

jessicajaniuk left a comment

Uh oh!

AndrewKushnir commented Feb 17, 2022

Uh oh!

alxhub commented Feb 18, 2022

Uh oh!

alxhub commented Feb 18, 2022

Uh oh!

angular-automatic-lock-bot bot commented Mar 21, 2022

Uh oh!

Uh oh!

perf(core): make more ApplicationModule providers tree-shakable #45102

perf(core): make more ApplicationModule providers tree-shakable #45102

Uh oh!

Conversation

AndrewKushnir commented Feb 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Type

Does this PR introduce a breaking change?

Uh oh!

Uh oh!

AndrewKushnir commented Feb 16, 2022

Uh oh!

atscott left a comment

Choose a reason for hiding this comment

Uh oh!

jessicajaniuk left a comment

Choose a reason for hiding this comment

Uh oh!

AndrewKushnir commented Feb 17, 2022

Uh oh!

alxhub commented Feb 18, 2022

Uh oh!

alxhub commented Feb 18, 2022

Uh oh!

angular-automatic-lock-bot bot commented Mar 21, 2022

Uh oh!

Uh oh!

perf(core): make more `ApplicationModule` providers tree-shakable #45102

perf(core): make more `ApplicationModule` providers tree-shakable #45102

AndrewKushnir commented Feb 16, 2022 •

edited

Loading