Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

feat: serve and bundle using webpack2. #132

Merged
merged 1 commit into from
Oct 5, 2016
Merged

Conversation

mprobst
Copy link
Contributor

@mprobst mprobst commented Sep 27, 2016

Including using the Angular AoT compiler ngc.

This does not hook up ngc with webpack yet, so probably should not be merged yet.

@ogix
Copy link
Contributor

ogix commented Oct 3, 2016

I wonder why did you leave only one webpack entry? For tree shaking to work? And I see polyfills are not loaded. Aren't they necessary?

@PatrickJS PatrickJS merged commit 6ec1e2d into angular:master Oct 5, 2016
@mprobst
Copy link
Contributor Author

mprobst commented Oct 5, 2016

@ogix if you have tree shaking working off a root, you don't really need multiple binaries anymore. It's nicer to start off from the one main.ts file and just include whatever it needs.

@gdi2290 as I said above, this PR had some issues and should probably not be merged yet, in particular no non-AoT development mode. At this point it might be easier to use one of Rob's webpack starters. I'd suggest rather rolling back.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants