Skip to content

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Oct 17, 2018

Checklist

Description

  • Allows for Angular 7 without peer dependency warnings
  • Now requires Firebase ^5.5.
  • Persistence settings can be passed in via the enablePersistence factory method or via the PersistenceSettingsToken injection token.
  • Now that firebase/app is less broken, pull in many of the types from there.
  • Allow configuration of Function region with the FunctionsRegionToken Injection Token

Code sample

imports: [
  AngularFirestoreModule.enablePersistence({experimentalTabSynchronization: true}),
  AngularFireFunctionsModule
],
providers: [
  { provide: FunctionsRegionToken, useValue: 'asia-northeast1' }
]

@jamesdaniels jamesdaniels self-assigned this Oct 17, 2018
@@ -10,11 +11,12 @@ export class AngularFirestoreModule {
/**
* Attempt to enable persistent storage, if possible
*/
static enablePersistence(): ModuleWithProviders {
static enablePersistence(persistenceSettings?: firestore.PersistenceSettings): ModuleWithProviders {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use PersistenceSettings from ./interface

@lehno
Copy link

lehno commented Oct 18, 2018

Waiting for this

@jamesdaniels jamesdaniels changed the title 5.1 release: support Firebase 5.5 and PersistenceSettings 5.1 release: support Firebase 5.5, multi-tab sync, and function region selection Oct 19, 2018
@jamesdaniels jamesdaniels changed the title 5.1 release: support Firebase 5.5, multi-tab sync, and function region selection 5.1 release: support Firebase 5.5, multi-tab sync, function region selection, and Angular 7 Oct 19, 2018
@@ -82,7 +83,7 @@
"systemjs": "^0.19.16",
"systemjs-builder": "^0.15.7",
"traceur": "0.0.96",
"typescript": ">=2.7.2 <2.8.0"
"typescript": ">=2.7.2 <2.8.0, >=3.1.1 <3.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there problems with supporting TypeScript 2.8.0, 2.9.2, 3.0.0,, 3.1.0 etc?

Copy link
Collaborator

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants