-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(performance): AngularFire Performance Monitoring #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FYI this has been released for testing on |
i love this too |
Need to work on the docs but I'm ready for review here. |
jamesdaniels
changed the title
WIP AngularFire Performance Monitoring
feat(perf): AngularFire Performance Monitoring
May 20, 2019
jamesdaniels
changed the title
feat(perf): AngularFire Performance Monitoring
feat(performance): AngularFire Performance Monitoring
May 20, 2019
…re2 into performance_monitoring
@davideast ready for review. Docs and tests could use some work. |
jhuleatt
reviewed
May 21, 2019
@davideast @jhuleatt gave it another pass. |
jamesdaniels
force-pushed
the
performance_monitoring
branch
from
May 23, 2019 08:50
276ca41
to
f415faa
Compare
jhuleatt
approved these changes
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic usage
Advanced usage
API
trace$(...) => Observable<void>
(name:string)
(name:string, options: TraceOptions)
Observable version of
firebase/perf
's.trace
method; the basis forAngularFirePerfomance
's pipes..subscribe()
is equivalent to calling.start()
.unsubscribe()
is equivalent to calling.stop()
<T>trace(...) => (Observable<T>) => Observable<T>
(name:string)
(name:string, options: TraceOptions)
Noop pipe, that traces the observable until the emission or completion.
<T>traceComplete(...) => (Observable<T>) => Observable<T>
(name:string)
(name:string, options: TraceOptions)
Noop pipe, that traces the observable until the completion.
<T>traceUntil(...) => (Observable<T>) => Observable<T>
(name:string, test: (T) => Boolean)
(name:string, test: (T) => Boolean, options: TraceOptions)
Noop pipe, that traces the observable until the first emission that passes the provided test.
<T>traceFirst(...) => (Observable<T>) => Observable<T>
(name:string)
(name:string, test: (T) => Boolean)
(name:string, options: TraceOptions)
(name:string, test: (T) => Boolean, options: TraceOptions)
Noop pipe, that traces the observable until the first emission or the first emission that matches the provided test.
TraceOptions
TBD explain how each option is used by
.trace$