Skip to content

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Oct 18, 2016

Checklist

Description

On first reading the Auth docs while doing the RC.4 to 2.1.0 upgrade and coming from angularfire2 beta.2 to beta.5, it was confusing if there was some new way to getting AuthProviders and AuthMethods. I was wondering if these come from the AngularFireModule now or if they came from a service or something. It would have saved me a lot of confusion to just specify that that they are still imported from angularfire2 like before. I.e. import { AngularFireModule, AuthProviders, AuthMethods } from 'angularfire2';

Also use AppComponent and AppModule for consistency with other docs.
Also fix typo of boostrap to bootstrap.

Fixes #627.

use AppComponent and AppModule for consistency with other docs
@davideast
Copy link
Collaborator

@Splaktar Thank you so much! 💯

@davideast davideast merged commit 892ecd4 into angular:master Oct 18, 2016
@Splaktar Splaktar deleted the improveAuthDocs branch October 18, 2016 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth docs don't demonstrate where to get AuthProviders, AuthMethods
3 participants