chore(sdk): Update to Firebase JS SDK 4.0 (breaking changes) #996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesdaniels
changed the title
markgoho
reviewed
May 24, 2017
| @@ -40,7 +41,7 @@ import * as firebase from 'firebase/app'; | |||
|
|
|||
| user: Observable<firebase.User>; | |||
| constructor(afAuth: AngularFireAuth) { | |||
| this.user = afAuth.authState; | |||
| this.user = afAuth.authState; // only triggered on sign-in/out (for old behavior use .idToken) | |||
There was a problem hiding this comment.
Do we need more here to explain how to use both? It seems like most users will just go with .idToken since it behaves like authState did. We should also update the main Authentication doc, but I guess we could do that after this PR is merged.
There was a problem hiding this comment.
Yes we'll definitely address this in the auth section of the docs.
davideast
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install,npm run build, andnpm testrun successfully? yesDescription
onIdTokenChanged, asonAuthTokenChangedis only triggered on sign-in/outSee the Firebase JS SDK changelog for more information.
Code sample
Triggered on sign-in, sign-out, and token change:
afAuth.idToken.subscribe(user => console.log(user));Triggered on sign-in/out only:
afAuth.authState.subscribe(user => console.log(user));