build: switch sass compilations to Dart Sass

This will be much faster, doesn't rely on workers that execute outside
of Bazel sandbox and can cause subtle confusion (see recent Sass
changes).

Author: devversion

WORKSPACE

@@ -12,16 +12,6 @@ http_archive(
     urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/5.8.4/rules_nodejs-5.8.4.tar.gz"],
 )
 
-# Add sass rules
-http_archive(
-    name = "io_bazel_rules_sass",
-    sha256 = "1c89680ca9cbbba33cb9cd462eb328e5782e14c0aa1286b794c71b5333385407",
-    strip_prefix = "rules_sass-1.68.0",
-    urls = [
-        "https://github.com/bazelbuild/rules_sass/archive/1.68.0.zip",
-    ],
-)
-
 # Add skylib which contains common Bazel utilities. Note that `rules_nodejs` would also
 # bring in the skylib repository but with an older version that does not support shorthands
 # for declaring Bazel build setting flags.
@@ -109,11 +99,6 @@ yarn_install(
     yarn_lock = "//tools/bazel/legacy-rnjs:yarn.lock",
 )
 
-# Setup the Sass rule repositories.
-load("@io_bazel_rules_sass//:defs.bzl", "sass_repositories")
-
-sass_repositories()
-
 load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")
 
 npm_translate_lock(
@@ -295,3 +280,13 @@ rules_browsers_setup_1()
 load("@rules_browsers//setup:step_2.bzl", "rules_browsers_setup_2")
 
 rules_browsers_setup_2()
+
+git_repository(
+    name = "rules_sass",
+    commit = "a32f75ce6fa0c5370bd3f29a5306478c681ad124",
+    remote = "https://github.com/devversion/rules_sass.git",
+)
+
+load("@rules_sass//src/toolchain:repositories.bzl", "setup_rules_sass")
+
+setup_rules_sass()

src/material/core/theming/tests/test-theming-bundle.scss

@@ -1,7 +1,7 @@
 // Imports the theming bundle. Needs to be an absolute bin-dir import path as on Windows,
 // runfiles are not symlinked, so the Sass compilation happens in the workspace directory
 // with the include paths being set to the `bazel-bin` directory.
-@use 'src/material' as mat;
+@use '../../../index' as mat;
 
 // Disable theme style duplication warnings. This test intentionally generates
 // the same themes multiple times.

tools/defaults.bzl

@@ -2,7 +2,7 @@
 
 load("@rules_pkg//:pkg.bzl", "pkg_tar")
 load("@build_bazel_rules_nodejs//:index.bzl", _pkg_npm = "pkg_npm")
-load("@io_bazel_rules_sass//:defs.bzl", _sass_binary = "sass_binary", _sass_library = "sass_library")
+load("@rules_sass//src:index.bzl", _sass_binary = "sass_binary", _sass_library = "sass_library")
 load("@npm//@angular/bazel:index.bzl", _ng_package = "ng_package")
 load("//:packages.bzl", "NO_STAMP_NPM_PACKAGE_SUBSTITUTIONS", "NPM_PACKAGE_SUBSTITUTIONS")
 load("//:pkg-externals.bzl", "PKG_EXTERNALS")
@@ -25,8 +25,12 @@ karma_web_test_suite = _karma_web_test_suite
 def sass_binary(sourcemap = False, include_paths = [], **kwargs):
     _sass_binary(
         sourcemap = sourcemap,
-        include_paths = include_paths + ["external/npm/node_modules"],
-        compiler = "//tools/sass:compiler",
+        include_paths = include_paths,
+        module_mappings = {
+            "@angular/cdk": "/".join([".."] * (native.package_name().count("/") + 1)) + "/src/cdk",
+            "@angular/material": "/".join([".."] * (native.package_name().count("/") + 1)) + "/src/material",
+            "@angular/material-experimental": "/".join([".."] * (native.package_name().count("/") + 1)) + "/src/material-experimental",
+        },
         **kwargs
     )
 

tools/extract-tokens/index.bzl

@@ -16,23 +16,23 @@ def _extract_tokens(ctx):
     expected_outputs = [output_file_name]
 
     # Pass the necessary information like the package name and files to the script.
-    args.add(ctx.label.package, output_file_name)
+    args.add(ctx.label.package)
+    args.add(output_file_name.short_path)
 
     for input_file in input_files:
-        args.add(input_file.path)
+        args.add(input_file.short_path)
 
     # Run the token extraction executable. Note that we specify the outputs because Bazel
     # can throw an error if the script didn't generate the required outputs.
     ctx.actions.run(
         inputs = input_files,
         env = {
-            # Not needed as we operate with source files; not inside `bazel-bin`.
-            "JS_BINARY__NO_CD_BINDIR": "1",
+            "BAZEL_BINDIR": ctx.bin_dir.path,
         },
         executable = ctx.executable._extract_tokens,
         outputs = expected_outputs,
         arguments = [args],
-        progress_message = "ExtractTokens",
+        progress_message = "Extracting theme tokens %s:%s" % (ctx.label.package, ctx.attr.name),
     )
 
     return DefaultInfo(files = depset(expected_outputs))