chore: minor cleanup in icon tests and virtual scrolling #11481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removes a file that wasn't being used for anything under `cdk-experimental/scrolling`. * Enables `strictMetadataEmit` for the scrolling package. * Fixes a test for the icons which was leaking out a warning message.
googlebot
added
the
cla: yes
mmalerba
approved these changes
May 23, 2018
mmalerba
added
pr: lgtm
action: merge
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
May 24, 2018
Fixes a path that wasn't updated in angular#11481, causing the Bazel build to fail.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
May 24, 2018
Fixes a path that wasn't updated in angular#11481, causing the Bazel build to fail.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
May 24, 2018
Fixes a path that wasn't updated in angular#11481, causing the Bazel build to fail.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
May 24, 2018
Fixes a path that wasn't updated in angular#11481, causing the Bazel build to fail.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
May 24, 2018
Fixes a path that wasn't updated in angular#11481, causing the Bazel build to fail.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
May 24, 2018
Fixes a path that wasn't updated in angular#11481, causing the Bazel build to fail.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
May 24, 2018
Fixes a path that wasn't updated in angular#11481, causing the Bazel build to fail.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
May 24, 2018
Fixes a path that wasn't updated in angular#11481, causing the Bazel build to fail.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
May 24, 2018
Restores a file that was removed in angular#11481 and ended up breaking the Bazel build.
mmalerba
pushed a commit
that referenced
this pull request
May 24, 2018
Restores a file that was removed in #11481 and ended up breaking the Bazel build.
mmalerba
pushed a commit
that referenced
this pull request
May 24, 2018
* Removes a file that wasn't being used for anything under `cdk-experimental/scrolling`. * Enables `strictMetadataEmit` for the scrolling package. * Fixes a test for the icons which was leaking out a warning message.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cdk-experimental/scrolling.strictMetadataEmitfor the scrolling package.