Skip to content

Conversation

crisbeto
Copy link
Member

Adds the BUILD.bazel file for the @angular/cdk-experimental/dialog package for consistency with everything else and to make it easier to eventually move it into the CDK.

@crisbeto crisbeto added the in progress This issue is currently in progress label May 28, 2018
@crisbeto crisbeto self-assigned this May 28, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 28, 2018
@crisbeto crisbeto assigned jelbourn and unassigned crisbeto May 28, 2018
@crisbeto crisbeto added pr: merge safe and removed in progress This issue is currently in progress labels May 28, 2018
@@ -0,0 +1 @@
declare var module: {id: string};
Copy link
Member Author

@crisbeto crisbeto May 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A note on this one: I still can't find a way to get Bazel to pick up the typings.d.ts that is one level up in cdk-experimental. This is also something that came up in #11481. Changing it in the tsconfig works when running it through Gulp, but not through Bazel.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's expected; Bazel doesn't allow referencing source files that aren't in the package's subtree; if you wanted to reference a common d.ts file, you have to create a build rule for it and depend on that.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels May 29, 2018
@josephperrott
Copy link
Member

@crisbeto Please rebase when you can

@josephperrott josephperrott added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels May 29, 2018
Adds the BUILD.bazel file for the `@angular/cdk-experimental/dialog` package for consistency with everything else and to make it easier to eventually move it into the CDK.
@crisbeto crisbeto force-pushed the dialog-bzl-config branch from 4a97994 to 9a8919d Compare May 30, 2018 07:24
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels May 30, 2018
@crisbeto
Copy link
Member Author

Rebased.

@josephperrott josephperrott merged commit 6e8202e into angular:master May 30, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants