fix(select): changed after checked error if selected option label changes #14797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
commented
Jan 11, 2019
src/lib/select/select.spec.ts
Outdated
| @@ -1374,10 +1374,26 @@ describe('MatSelect', () => { | |||
|
|
|||
| fixture.componentInstance.foods[1].viewValue = 'Calzone'; | |||
| fixture.detectChanges(); | |||
| tick(); | |||
There was a problem hiding this comment.
Note: this is only necessary for our assertions to pass, it won't be necessary for people to change their existing tests.
jelbourn
added
pr: lgtm
action: merge
|
Is this going to be checked in soon @crisbeto ? seems to have been ready for awhile. |
|
@crisberto The process seems to be hanging. What can we do to get it in progress again and get the fix implemented? |
andrewseguin
added
the
P4
crisbeto
force-pushed
the
14793/select-changed-after-checked
branch
from
136e963 to
bd4c26d
Compare
crisbeto
force-pushed
the
14793/select-changed-after-checked
branch
from
bd4c26d to
0db2c92
Compare
crisbeto
force-pushed
the
14793/select-changed-after-checked
branch
from
0db2c92 to
583237d
Compare
…nges Fixes a "changed after checked" error being thrown by `mat-select`, if the label of the selected `mat-option` changes. Also fixes that the trigger value doesn't get updated until the next change detection. Fixes angular#14793.
crisbeto
force-pushed
the
14793/select-changed-after-checked
branch
from
583237d to
ad1618c
Compare
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Aug 5, 2021
…nges Fixes a "changed after checked" error that is thrown if the label of a selected option changes dynamically. This is alternate approach to angular#14797 which was tricky to land, because it introduced an extra timeout. Fixes angular#14793.
|
Closing in favor of #23315. |
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Aug 5, 2021
…nges Fixes a "changed after checked" error that is thrown if the label of a selected option changes dynamically. This is alternate approach to angular#14797 which was tricky to land, because it introduced an extra timeout. Fixes angular#14793.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a "changed after checked" error being thrown by
mat-select, if the label of the selectedmat-optionchanges.Also fixes that the trigger value doesn't get updated until the next change detection.
Fixes #14793.