fix(material/select): changed after checked error if option label changes #23315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
google-cla
bot
added
the
cla: yes
crisbeto
force-pushed
the
14793/option-changed-after-checked
branch
from
a80f88b to
c655c4c
Compare
jelbourn
reviewed
Aug 9, 2021
andrewseguin
removed
the
cla: yes
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
14793/option-changed-after-checked
branch
2 times, most recently
from
e999350 to
bac6a51
Compare
…nges Fixes a "changed after checked" error that is thrown if the label of a selected option changes dynamically. This is alternate approach to angular#14797 which was tricky to land, because it introduced an extra timeout. Fixes angular#14793.
crisbeto
force-pushed
the
14793/option-changed-after-checked
branch
from
bac6a51 to
1efa47d
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a "changed after checked" error that is thrown if the label of a selected option changes dynamically.
This is alternate approach to #14797 which was tricky to land, because it introduced an extra timeout.
Fixes #14793.
Note: I'm bumping this to a P2, because the related issue has been getting activity consistently for a long time now.