Skip to content

refactor: move DOCUMENT import from platform-browser to common #15470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2019
Merged

refactor: move DOCUMENT import from platform-browser to common #15470

merged 1 commit into from
Mar 27, 2019

Conversation

CaerusKaru
Copy link
Member

In preparation for angular/angular#28117, we need to migrate the import for the DOCUMENT token to avoid using the deprecated symbol from platform-browser.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 14, 2019
@CaerusKaru
Copy link
Member Author

angular/angular#28117 is blocked on this PR

@CaerusKaru CaerusKaru mentioned this pull request Mar 14, 2019
Closed
14 tasks
crisbeto
crisbeto approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 14, 2019
jelbourn
jelbourn approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the P2 The issue is important to a large percentage of users, with a workaround label Mar 21, 2019
@jelbourn jelbourn added this to the 8.0.0 milestone Mar 21, 2019
@jelbourn jelbourn merged commit 61af10b into angular:master Mar 27, 2019
@CaerusKaru CaerusKaru deleted the adam/document branch March 27, 2019 14:43
jelbourn pushed a commit that referenced this pull request Apr 4, 2019
@CaerusKaru @jelbourn
refactor: move DOCUMENT import from platform-browser to common (#15470)
4cccce1
@CaerusKaru CaerusKaru restored the adam/document branch April 17, 2019 16:14
@CaerusKaru CaerusKaru mentioned this pull request Apr 17, 2019
Merged
@CaerusKaru CaerusKaru deleted the adam/document branch April 17, 2019 16:21
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@CaerusKaru @jelbourn @crisbeto @googlebot