Skip to content

fix(overlay): add panelClass from position to the overlay #15853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2019
Merged

fix(overlay): add panelClass from position to the overlay #15853

merged 1 commit into from
May 13, 2019

Conversation

ienzam
Copy link
Contributor

@ienzam ienzam commented Apr 17, 2019

CdkConnectedOverlay directive was ignoring panelClass from
cdkConnectedOverlayPositions. This change adds support to add panelClass
from positions to the overlay.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 17, 2019
crisbeto
crisbeto reviewed Apr 18, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the PR is labelled for dialog, even though it doesn't have anything to do with the dialog.

crisbeto
crisbeto approved these changes Apr 19, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 19, 2019
@ienzam
Copy link
Contributor Author

ienzam commented Apr 19, 2019

@crisbeto for the title issue (dialog vs overlay): should I create a new PR or just change the title of this PR?

@crisbeto
Copy link
Member

crisbeto commented Apr 19, 2019 •
edited
Loading

You can rename the PR and you can force-push to change the title of the commit.

@ienzam
fix(overlay): add panelClass from position to the overlay
bb14fec 
CdkConnectedOverlay directive was ignoring panelClass from
cdkConnectedOverlayPositions. This change adds support to add panelClass
from positions to the overlay.
@ienzam ienzam changed the title fix(dialog): add panelClass from position to the overlay fix(overlay): add panelClass from position to the overlay Apr 23, 2019
@ienzam
Copy link
Contributor Author

ienzam commented Apr 23, 2019

You can rename the PR and you can force-push to change the title of the commit.

Thanks, done.

@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@ienzam
Copy link
Contributor Author

ienzam commented May 9, 2019

Hi,
This is my first PR to Angular. Is there anything else I need to do to merge this or do I just need to wait?

jelbourn
jelbourn approved these changes May 12, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 00226f0 into angular:master May 13, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@ienzam @RudolfFrederiksen
fix(overlay): add panelClass from position to the overlay (angular#15853
22c4f19 
)

CdkConnectedOverlay directive was ignoring panelClass from
cdkConnectedOverlayPositions. This change adds support to add panelClass
from positions to the overlay.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ienzam @crisbeto @jelbourn @googlebot @mmalerba