Skip to content

fix(overlay): add panelClass from position to the overlay #15853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2019
Merged

fix(overlay): add panelClass from position to the overlay #15853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/cdk/overlay/overlay-directives.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,23 @@ describe('Overlay directives', () => {
expect(Math.floor(overlayRect.left)).toBe(Math.floor(triggerRect.left) + 20);
});

it('should take the offset from the position', () => {
fixture.componentInstance.positionOverrides = [{
originX: 'start',
originY: 'top',
overlayX: 'start',
overlayY: 'top',
panelClass: 'custom-class'
}];

fixture.componentInstance.isOpen = true;
fixture.detectChanges();

const panel = getPaneElement();
expect(panel.classList).toContain('custom-class');
expect(panel.classList).toContain('cdk-test-panel-class');
});

it('should be able to set the viewport margin', () => {
expect(fixture.componentInstance.connectedOverlayDirective.viewportMargin).not.toBe(10);

Expand Down
3 changes: 2 additions & 1 deletion src/cdk/overlay/overlay-directives.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,8 @@ export class CdkConnectedOverlay implements OnDestroy, OnChanges {
overlayX: currentPosition.overlayX,
overlayY: currentPosition.overlayY,
offsetX: currentPosition.offsetX || this.offsetX,
offsetY: currentPosition.offsetY || this.offsetY
offsetY: currentPosition.offsetY || this.offsetY,
panelClass: currentPosition.panelClass || undefined,
}));

return positionStrategy
Expand Down