Skip to content

chore: add skeleton files for MDC-based implementation of chips #15965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

chore: add skeleton files for MDC-based implementation of chips #15965

wants to merge 0 commits into from

Conversation

vanessanschmitt
Copy link
Collaborator

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 6, 2019
@mmalerba mmalerba requested review from mmalerba and jelbourn May 7, 2019 15:57
mmalerba
mmalerba requested changes May 7, 2019
View reviewed changes
jelbourn
jelbourn approved these changes May 7, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from that one file name

@vanessanschmitt
Copy link
Collaborator Author

Thanks for the feedback! I pushed the requested changes.

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels May 7, 2019
@jelbourn jelbourn added the P2 The issue is important to a large percentage of users, with a workaround label May 7, 2019
@jelbourn jelbourn closed this May 10, 2019
@vanessanschmitt vanessanschmitt mentioned this pull request May 10, 2019
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees

@jelbourn jelbourn

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vanessanschmitt @jelbourn @mmalerba @googlebot