Skip to content

Conversation

vanessanschmitt
Copy link
Collaborator

Same changes as #15965

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 10, 2019
@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround pr: lgtm action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels May 10, 2019
@ngbot
Copy link

ngbot bot commented May 10, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure conflicts with base branch "master"
    pending status "ci/circleci: bazel_build_test" is pending
    pending status "ci/circleci: build_release_packages" is pending
    pending status "ci/circleci: e2e_tests" is pending
    pending status "ci/circleci: tests_browserstack" is pending
    pending status "ci/circleci: tests_local_browsers" is pending
    pending status "ci/circleci: tests_saucelabs" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn jelbourn merged commit 99f3c2d into angular:master May 10, 2019
@mmalerba
Copy link
Contributor

mmalerba commented Jun 10, 2019

related to #16173

RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants