Skip to content

chore: switch examples to secondary entry-points #15977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2019
Merged

chore: switch examples to secondary entry-points #15977

merged 1 commit into from
May 10, 2019

Conversation

devversion
Copy link
Member

@devversion devversion commented May 8, 2019 •
edited
Loading

Since the primary entry-point @angular/material is now deprecated
with V8, we should no longer use the deprecated entry-point in our
examples.

I'm planning a follow-up that does the same for the dev-app/e2e-app.

@devversion
chore: switch examples to secondary entry-points
7b54bbf 
Since the primary entry-point `@angular/material` is now deprecated
with V8, we should no longer use the deprecated entry-point in our
examples.
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels May 8, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 8, 2019
jelbourn
jelbourn approved these changes May 8, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added P2 The issue is important to a large percentage of users, with a workaround pr: lgtm action: merge The PR is ready for merge by the caretaker labels May 8, 2019
This was referenced May 9, 2019
Merged
Merged
@jelbourn
Copy link
Member

jelbourn commented May 9, 2019 •
edited
Loading

Caretaker: merge #15983 and #15987 after merging this

@jelbourn jelbourn added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label May 9, 2019
@jelbourn jelbourn merged commit f8a2a9d into angular:master May 10, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@devversion @RudolfFrederiksen
chore: switch examples to secondary entry-points (angular#15977)
5c8fd8a 
Since the primary entry-point `@angular/material` is now deprecated
with V8, we should no longer use the deprecated entry-point in our
examples.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devversion @jelbourn @googlebot