Skip to content

chore: switch e2e-app to secondary entry-points #15987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 10, 2019
Merged

chore: switch e2e-app to secondary entry-points #15987

merged 3 commits into from
May 10, 2019

Conversation

devversion
Copy link
Member

@devversion devversion commented May 9, 2019 •
edited
Loading

Since the primary entry-point @angular/material is now deprecated
with V8, we should no longer use the deprecated entry-point in
our e2e-app.

Blocked on #15977

devversion added 3 commits May 8, 2019 16:20
@devversion
chore: switch examples to secondary entry-points
7b54bbf 
Since the primary entry-point `@angular/material` is now deprecated
with V8, we should no longer use the deprecated entry-point in our
examples.
@devversion
chore: switch e2e-app to secondary entry-points
477849e 
Since the primary entry-point @angular/material is now deprecated
with V8, we should no longer use the deprecated entry-point in
our e2e-app.
@devversion
build: switch e2e-app bazel target to fine-grained deps
2583f4c
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 9, 2019
@devversion devversion added blocked This issue is blocked by some external factor, such as a prerequisite PR target: patch This PR is targeted for the next patch release pr: merge safe labels May 9, 2019
jelbourn
jelbourn approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn mentioned this pull request May 9, 2019
Merged
@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels May 10, 2019
@jelbourn jelbourn merged commit 8ab0f63 into angular:master May 10, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@devversion @RudolfFrederiksen
chore: switch e2e-app to secondary entry-points (angular#15987)
9fb1ccb 
Since the primary entry-point `@angular/material` is now deprecated
with V8, we should no longer use the deprecated entry-point in our
examples.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devversion @jelbourn @googlebot